Code duplication of Convert_CompBezierCurvesToBSplineCurve and ShapeConstruct_CompBezierCurvesToBSplineCurve

Timo Roth's picture
Timo Roth
Mon, 02/22/2016 - 17:27
Forums: 
Refactoring

The code of Convert_CompBezierCurvesToBSplineCurve and ShapeConstruct_CompBezierCurvesToBSplineCurve is nearly the same. Looking at the history of both, the only difference seems to come from "0025256: Small optimization in Convert comp bezier to BSpline". Why are there these two classes? Shouldn't the ShapeConstruct class be better removed to avoid code duplication?

Regards

Andrey BETENEV's picture
Andrey BETENEV
Tue, 03/08/2016 - 20:18

Hello Timo,

You are right, these classes are duplicates (even if each contain some specific amendments made after separation). Thank you for spotting this! Classes from ShapeConstruct are not used inside OCCT; they shall be removed. I have registered issue #27234 for that.

Andrey