View Issue Details

IDProjectCategoryView StatusDate SubmittedLast Update
0009026CommunityOCCT:Visualizationpublic2005-06-01 10:042006-06-29 09:15
ReportersanAssigned Toael 
PrioritynormalSeveritytrivial 
Status closedResolutionfixed 
OSAll 
Summary0009026: [OCC Forum: thread 8263] Missing braces in FindSelectedOwnerFromShape function
DescriptionThere is a programmatic error in AIS_LocalContext::FindSelectedOwnerFromShape
() - multi-line "if" block with missing braces.

***************************************************

Original message from OCC Forum [posted by ngoctn]:


I've tested with FindSelectedOwnerFromShape function from AIS_LocalContext, and
it did works correctly (missed {} after if(EO->Shape() == sh) statement).

Here is origin code:
...
...
if(!Tr.IsNull()){

EO = *((Handle(SelectMgr_EntityOwner)*)&Tr);
if(EO->HasShape())
if ( EO->Shape() == sh)
found =Standard_True;
break;
}

And here is modified code (works correctly).

...
...
if(!Tr.IsNull()){

EO = *((Handle(SelectMgr_EntityOwner)*)&Tr);
if(EO->HasShape())
if ( EO->Shape() == sh)
{//missing
found =Standard_True;
break;
}//missing
}

Ngoc Truong Nguyen - DASI Center
Additional information
and documentation updates		Documentation remark, added by Alexey Ermolayev (ael) 2005-06-29 10:52:15:

Changes:
Optimization of the FindSelectedOwnerFromShape() method.
Modified entities:
AIS/AIS_LocalContext_1.cxx/FindSelectedOwnerFromShape: modified algorithm;
SelectMgr/SelectMgr_ViewerSelector.cdl/SelectMgr_ViewerSelector.lxx: added
method Primitives().
TagsNo tags attached.
Test case number

Attached Files

Activities

2005-06-01 08:04

 

patch.tar.gz (8,745 bytes)

2005-06-02 06:59

 

fix_for_occ9026.zip (15,140 bytes)

2005-06-29 10:52

 

ael-OCC9026-v1.tar.gz (11,893 bytes)

Issue History

Date Modified Username Field Change
2005-06-01 10:08 san CC => szv
2005-06-02 09:00 bugmaster Assigned To bugmaster => san
2005-06-02 09:00 bugmaster Status new => assigned
2005-06-07 10:38 san Assigned To san => ael
2005-07-07 11:42 ael Status assigned => resolved
2005-07-22 07:59 abv CC => abv
2005-07-22 08:01 bugmaster Customer => Community
2005-08-05 18:27 apv CC => apv, aki
2005-08-19 16:57 aki Status resolved => tested
2005-08-23 16:04 bugmaster CC => imv
2005-08-29 11:37 bugmaster Status tested => verified
2005-10-31 18:29 bugmaster Status verified => closed
2005-10-31 18:29 bugmaster Resolution @0@ => fixed
2011-08-02 11:24 bugmaster Category OCCT:VIZ => OCCT:Visualization