View Issue Details

IDProjectCategoryView StatusLast Update
0022822Open CASCADEOCCT:Data Exchangepublic2012-03-29 17:26
Reportervro Assigned Tobugmaster  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
PlatformWindowsOSVC++ 2005 
Product Version6.5.3 
Target Version6.5.3Fixed in Version6.5.3 
Summary0022822: Skipping of the first and the last edges of a wire for opened wires
DescriptionThere is a bug in consideration of self-intersection in the method ShapeAnalysis_Wire::CheckSelfIntersection(). A closed wire is processed correctly. But an opened wire skips the first and the last edges from consideration.
TagsNo tags attached.
Test case numberchl 934 R3

Attached Files

Activities

vro

2011-12-02 14:47

developer  

selfIntersectingOpenWire.png (2,734 bytes)   

vro

2011-12-02 14:51

developer   ~0018709

The method ShapeAnalysis_Wire::CheckSelfIntersection() returns false for the wire seldIntersectingOpenWire.png attached to this issue.

vro

2011-12-02 15:10

developer   ~0018710

The fix is commited to http://svn/svn/occt/branches/22822. The only file is modified is ShapeAnalysis_Wire.cxx

vro

2011-12-02 15:14

developer   ~0018712

Dear Bugmaster, revise please the fix (or find a guy who would do it). Many thanks!

bugmaster

2011-12-02 16:00

administrator   ~0018718

Dear Vlad,

You must define reviewer yourself, set status resolved and assign issue to reviewer.

vro

2011-12-02 16:08

developer   ~0018719

Dear Catia,
Could you review my fix, please?
Thanks,
  Vlad

vro

2011-12-02 17:10

developer  

vro

2011-12-02 17:12

developer   ~0018723

The file selfIntersectingOpenWire.brep represents an open self-intersecting wire.

epa

2011-12-02 17:19

developer   ~0018724

I have no remarks; please test

vro

2011-12-05 08:08

developer   ~0018731

Dear Cathia,
Thank you very much!
:-)

vro

2011-12-05 08:08

developer   ~0018732

Could you integrate the fix into OCCT, please?

mkv

2011-12-08 16:50

tester   ~0018797

Dear BugMaster,
Workbench KAS:dev:apn-OCC22822-occt was created from SVN branch http://svn/svn/occt/branches/OCC22822
(and apn-OCC22822-products from trunk) and compiled on Linux platform.

There are not regressions in apn-OCC22822-products regarding to KAS:dev:products-652-opt.

See results in /QADisk/occttests/results/KAS/dev/apn-OCC22822-products_06122011/lin
See reference results in /QADisk/occttests/results/KAS/dev/products-652-opt_23092011/lin
See test cases in /QADisk/occttests/tests/ED
N.B. In order to launch testing case you can make use the following instructions
http://doc/doku.php?id=occt:certification

epa

2011-12-08 17:43

developer   ~0018802

Dear Vlad,

Please create the new draw test command to check usage of ShapeAnalysis

Regards,
Kate

vro

2012-02-01 12:48

developer   ~0019327

Dear Catherina,
Dear Mikhail,
A new draw command checkselfintersection is added in 22822 branch. It is implemented in SWDRAW_ShapeAnalysis.cxx.
Use the command please with an attached shape. Before modification (before bug correction) the command returns false (no self-intersection). After the modification (when the bug is fixed) the command returns true (detects a self-intersection).
Any questions are welcome!
Vlad

vro

2012-02-01 12:49

developer   ~0019329

A draw command for tests is ready.

bugmaster

2012-02-07 11:46

administrator   ~0019425

Last edited: 2012-02-07 12:04

Mikhail,

Please create testing case and change status to tested.

mkv

2012-02-07 19:36

tester  

R3 (851 bytes)   

mkv

2012-02-08 12:15

tester   ~0019454

Dear BugMaster,
Test case for this fix is chl/934/R3. It is OK.

bugmaster

2012-02-10 14:15

administrator   ~0019505

Integrated into trunk of occt repository

Date: 2012-02-10 13:57:58 +0400 (Fri, 10 Feb 2012)
New Revision: 10407

Modified:
   trunk/src/SWDRAW/SWDRAW_ShapeAnalysis.cxx
   trunk/src/ShapeAnalysis/ShapeAnalysis_Wire.cxx

Related Changesets

occt: master ef57920a

2012-02-10 09:57:58

vro


Committer: bugmaster Details Diff
0022822: Skipping of the first and the last edges of a wire for opened wires Affected Issues
0022822
mod - src/ShapeAnalysis/ShapeAnalysis_Wire.cxx Diff File
mod - src/SWDRAW/SWDRAW_ShapeAnalysis.cxx Diff File

Issue History

Date Modified Username Field Change
2011-12-02 12:21 vro New Issue
2011-12-02 12:21 vro Assigned To => vro
2011-12-02 14:47 vro File Added: selfIntersectingOpenWire.png
2011-12-02 14:51 vro Note Added: 0018709
2011-12-02 15:10 vro Note Added: 0018710
2011-12-02 15:14 vro Note Added: 0018712
2011-12-02 16:00 bugmaster Note Added: 0018718
2011-12-02 16:00 bugmaster Status new => assigned
2011-12-02 16:07 vro Assigned To vro => epa
2011-12-02 16:07 vro Status assigned => resolved
2011-12-02 16:08 vro Note Added: 0018719
2011-12-02 17:10 vro File Added: selfIntersectingOpenWire.brep
2011-12-02 17:12 vro Note Added: 0018723
2011-12-02 17:19 epa Note Added: 0018724
2011-12-02 17:19 epa Status resolved => reviewed
2011-12-02 17:20 epa Assigned To epa => vro
2011-12-05 08:08 vro Note Added: 0018731
2011-12-05 08:08 vro Note Added: 0018732
2011-12-05 08:08 vro Assigned To vro => bugmaster
2011-12-05 08:08 vro Status reviewed => assigned
2011-12-05 08:54 abv Status assigned => resolved
2011-12-05 08:54 abv Assigned To bugmaster => vro
2011-12-05 08:54 abv Status resolved => reviewed
2011-12-08 10:03 abv Target Version => 6.5.3
2011-12-08 16:50 mkv Note Added: 0018797
2011-12-08 17:43 epa Note Added: 0018802
2011-12-14 21:02 mkv Status reviewed => assigned
2012-02-01 12:48 vro Note Added: 0019327
2012-02-01 12:49 vro Note Added: 0019329
2012-02-01 12:49 vro Status assigned => resolved
2012-02-01 12:51 abv Status resolved => reviewed
2012-02-01 15:58 vro Assigned To vro => epa
2012-02-01 15:58 vro Status reviewed => assigned
2012-02-01 16:26 abv Assigned To epa => bugmaster
2012-02-01 16:26 abv Status assigned => feedback
2012-02-07 11:46 bugmaster Note Added: 0019425
2012-02-07 11:47 bugmaster Assigned To bugmaster => mkv
2012-02-07 12:04 bugmaster Note Edited: 0019425
2012-02-07 19:36 mkv File Added: R3
2012-02-08 12:15 mkv Note Added: 0019454
2012-02-08 12:16 mkv Test case number => chl 934 R3
2012-02-08 12:16 mkv Status feedback => reviewed
2012-02-08 12:16 mkv Status reviewed => tested
2012-02-10 14:15 bugmaster Note Added: 0019505
2012-02-10 14:15 bugmaster Status tested => verified
2012-02-10 14:15 bugmaster Resolution open => fixed
2012-02-10 14:15 bugmaster Assigned To mkv => vro
2012-03-29 17:26 bugmaster Changeset attached => occt master ef57920a