View Issue Details

IDProjectCategoryView StatusDate SubmittedLast Update
0023989Open CASCADEOCCT:Modeling Algorithmspublic2013-05-23 15:292013-06-13 11:35
ReporternbvAssigned Tobugmaster  
PrioritynormalSeverityminor 
Status closedResolutionduplicate 
Summary0023989: It is necessary to replace bad shapes in test's base with new valid shapes.
DescriptionIn test's base there are shapes, which are not valid in respect to #23675 bug. In attached archive these shapes are fixed. It is necessary to replace existing shapes with new.

Checkshape on master considers new shapes as valid.
TagsNo tags attached.
Test case number

Attached Files

Activities

nbv

2013-05-23 15:29

developer  

fixed.zip (2,808,439 bytes)

ifv

2013-05-23 15:34

developer   ~0024494

Ok for replacing

nbv

2013-05-23 15:42

developer   ~0024495

Dears Mikhail and Bugmaster.
Do not close this bug until closed bug #23675.

abv

2013-06-06 09:36

manager   ~0024643

Nikolai, please provide detailed description how the new shapes have been produced and what is the difference. Further, updating our local database would not fix the files that OCCT users might still have with the same problems -- what will happen to them? We need to have clear explanation what is wrong and how to fix that.

nbv

2013-06-06 10:14

developer   ~0024644

Dear Andrei!

In branch CR23675_12 draw-commands "ffixpcu" (for fixing single face) and "sfixpcu" (for fixing shape with many faces) were added. These commands are defined in "SWDRAW_ShapeFix.cxx" file.

Main idea is:
Periodic-surface, which underlies the face, is trimmed anew and is put in source face. Thereby, we get a face, which lies into surface boundary.

When we fix the shape, it is exploded on a faces and every face, which has "BRepCheck_OutOfSurfaceBoundary" status, is fixed according to just described algorithm.

On attached shapes, this algorithm is checked. They became valid. However, correct trimming algorithm is on development stage. Therefore, I ask, do not close this bug until closed bug #0023675.

nbv

2013-06-06 10:50

developer   ~0024646

Maybe, more rightly, do not change shapes, and call "sfixpcu" command in test's cases, where these shapes are used?

Moreover, in algorithms, for which a problem of going a face out of surface boundary is actual, function "BRepLib::RefineFace(...)" is built (this function is used by "ffixpcu" DRAW-command). It can be called for fixing both source and resulting shapes.

abv

2013-06-06 10:55

manager   ~0024648

I suggest this change (explicit call of fixing command for invalid shapes) should be added in relevant test cases in the same branch where fix for #23675 is done.

nbv

2013-06-06 14:34

developer   ~0024663

Then, I think, this bug can be closed.

Invalid shapes will be fixed by new DRAW-command (it calling will be added in test's cases) in CR23675_... branches.

ifv

2013-06-11 09:53

developer   ~0024720

Ok

bugmaster

2013-06-13 11:35

administrator   ~0024741

Invalid shapes will be fixed by new DRAW-command in CR23675 branche.

Issue History

Date Modified Username Field Change
2013-05-23 15:29 nbv New Issue
2013-05-23 15:29 nbv Assigned To => ifv
2013-05-23 15:29 nbv File Added: fixed.zip
2013-05-23 15:30 nbv Assigned To ifv => nbv
2013-05-23 15:30 nbv Status new => assigned
2013-05-23 15:32 nbv Assigned To nbv => ifv
2013-05-23 15:32 nbv Status assigned => resolved
2013-05-23 15:34 ifv Note Added: 0024494
2013-05-23 15:34 ifv Status resolved => reviewed
2013-05-23 15:42 nbv Note Added: 0024495
2013-05-23 15:45 mkv Assigned To ifv => mkv
2013-06-06 09:36 abv Note Added: 0024643
2013-06-06 09:36 abv Assigned To mkv => nbv
2013-06-06 09:36 abv Status reviewed => feedback
2013-06-06 10:14 nbv Note Added: 0024644
2013-06-06 10:15 nbv Assigned To nbv => abv
2013-06-06 10:50 nbv Note Added: 0024646
2013-06-06 10:51 nbv Assigned To abv => nbv
2013-06-06 10:51 nbv Assigned To nbv => mkv
2013-06-06 10:55 abv Note Added: 0024648
2013-06-06 14:34 nbv Note Added: 0024663
2013-06-06 14:34 nbv Assigned To mkv => ifv
2013-06-06 14:34 nbv Status feedback => resolved
2013-06-11 09:53 ifv Note Added: 0024720
2013-06-11 09:53 ifv Status resolved => reviewed
2013-06-11 10:23 mkv Assigned To ifv => bugmaster
2013-06-11 10:23 mkv Status reviewed => feedback
2013-06-13 11:35 bugmaster Note Added: 0024741
2013-06-13 11:35 bugmaster Status feedback => closed
2013-06-13 11:35 bugmaster Resolution open => duplicate