View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0025719 | Community | OCCT:Modeling Algorithms | public | 2015-01-19 18:14 | 2015-05-26 10:13 |
| Reporter | Istvan Csanady | Assigned To | bugmaster | ||
| Priority | normal | Severity | crash | ||
| Status | closed | Resolution | fixed | ||
| Target Version | 6.9.0 | Fixed in Version | 6.9.0 | ||
| Summary | 0025719: Boolean operations can crash | ||||
| Description | In special circumstances, boolean operations can crash. See the forum topic here: http://dev.opencascade.org/index.php?q=node/1048 I could reproduce it with the attached file, but because of the nature of the problem, it may not be reproducible always. The repro requires OS X (because of the dispatch API). Fix is attached. | ||||
| Steps To Reproduce | not applicable | ||||
| Additional information and documentation updates | Class math_BFGS does not call Perform() in its constructor any more; it must be called explicitly. | ||||
| Tags | No tags attached. | ||||
| Test case number | Not needed | ||||
|
|
|
|
|
The patch is incomplete. It misses changes in the package AppParCurves connected with changes in API of math_BFGS. |
|
|
Branch CR25719 has been created by msv. SHA-1: 56fb79d1470df05a3f18801a11dbc04f6815cc6c Detailed log of new commits: Author: msv Date: Mon Jan 19 20:34:52 2015 +0300 0025719: Boolean operations can crash Suppress math_BFGS constructor that calls the method Perform that in its turn calls the virtual method IsSolutionReached. |
|
|
I have completed the patch. Andrey, please review the branch CR25719. |
|
|
math_GlobOptMin.cxx, line 143: indentation is broken |
|
|
Reviewed, please test |
|
|
Sorry for the incomplete patch, I accidentally made the changes in the copied file. |
|
|
Branch CR25719 has been updated by msv. SHA-1: 410528df78e3ef9b726368d1ae8c20b8a69bfbbe Detailed log of new commits: Author: msv Date: Tue Jan 20 10:01:53 2015 +0300 Correct indentation. |
|
|
Dear bugmaster, please test. |
|
|
Dear BugMaster, Branch CR25719 from occt git-repository (and master from products git-repository) was compiled on Linux, MacOS and Windows platforms in Release mode. SHA-1: 410528df78e3ef9b726368d1ae8c20b8a69bfbbe There is compilation error on PRODUCTS: Linux: ../../../../src/BestFitAPI/BestFitAPI_Algo.cxx:644: error: no matching function for call to ‘math_BFGS::math_BFGS(BestFitAlgo_Function&, math_Vector&, Standard_Real&, const Standard_Integer&)’ WNT: ..\..\..\src\BestFitAPI\BestFitAPI_Algo.cxx(644): error C2664: 'math_BFGS::math_BFGS(const Standard_Integer,const Standard_Real,const Standard_Integer,const Standard_Real)' : cannot convert parameter 1 from 'BestFitAlgo_Function' to 'const Standard_Integer' |
|
|
Branch CR25719 has been updated forcibly by msv. SHA-1: bb50c47cac355c06040675f63235999dfe153cb7 |
|
|
Andrey, I have fixed compilation error. The new branch CR25719 is created in occt-products. I also re-based the branch CR25719 in occt on current master. |
|
|
Dear BugMaster, Branch CR25719 from occt git-repository (and CR25719 from products git-repository) was compiled on Linux, MacOS and Windows platforms and tested in Release mode. SHA-1: bb50c47cac355c06040675f63235999dfe153cb7 Number of compiler warnings: occt component : Linux: 18 (18 on master) Windows: 0 (0 on master) products component : Linux: 11 (11 on master) Windows: 1 (1 on master) Regressions/Differences: No regressions Testing cases: Not needed Testing on Linux: Total MEMORY difference: 369670892 / 370114884 Total CPU difference: 53685.890000000196 / 51750.710000000094 Testing on Windows: Total MEMORY difference: 275634060 / 275769192 Total CPU difference: 51731.6875 / 38148.296875 There are not differences in images found by testdiff. |
|
|
Branch CR25719 has been deleted by inv. SHA-1: bb50c47cac355c06040675f63235999dfe153cb7 |
|
occt: master 07f1a2e6 2015-01-23 15:07:15
Committer: bugmaster Details Diff |
0025719: Boolean operations can crash Suppress math_BFGS constructor that calls the method Perform that in its turn calls the virtual method IsSolutionReached. |
Affected Issues 0025719 |
|
| mod - src/AppParCurves/AppParCurves_BSpGradient_BFGS.gxx | Diff File | ||
| mod - src/AppParCurves/AppParCurves_Gradient_BFGS.gxx | Diff File | ||
| mod - src/math/math_BFGS.cdl | Diff File | ||
| mod - src/math/math_BFGS.cxx | Diff File | ||
| mod - src/math/math_GlobOptMin.cxx | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2015-01-19 18:14 | Istvan Csanady | New Issue | |
| 2015-01-19 18:14 | Istvan Csanady | Assigned To | => msv |
| 2015-01-19 18:14 | Istvan Csanady | File Added: fix_and_repro.zip | |
| 2015-01-19 20:13 |
|
Note Added: 0036222 | |
| 2015-01-19 20:35 | git | Note Added: 0036223 | |
| 2015-01-19 20:38 |
|
Note Added: 0036224 | |
| 2015-01-19 20:38 |
|
Assigned To | msv => abv |
| 2015-01-19 20:38 |
|
Status | new => resolved |
| 2015-01-19 20:38 |
|
Steps to Reproduce Updated | |
| 2015-01-19 21:01 |
|
Relationship added | related to 0025720 |
| 2015-01-19 21:57 |
|
Note Added: 0036225 | |
| 2015-01-19 21:58 |
|
Additional Information Updated | |
| 2015-01-19 21:58 |
|
Note Added: 0036226 | |
| 2015-01-19 21:58 |
|
Assigned To | abv => bugmaster |
| 2015-01-19 21:58 |
|
Status | resolved => reviewed |
| 2015-01-20 09:51 | Istvan Csanady | Note Added: 0036232 | |
| 2015-01-20 10:02 | git | Note Added: 0036234 | |
| 2015-01-20 10:02 |
|
Note Added: 0036235 | |
| 2015-01-22 13:47 | apn | Test case number | => Not needed |
| 2015-01-22 13:47 | apn | Assigned To | bugmaster => apn |
| 2015-01-23 15:25 | apn | Note Added: 0036445 | |
| 2015-01-23 15:25 | apn | Assigned To | apn => msv |
| 2015-01-23 15:25 | apn | Status | reviewed => assigned |
| 2015-01-23 18:19 | git | Note Added: 0036465 | |
| 2015-01-23 18:23 |
|
Note Added: 0036466 | |
| 2015-01-23 18:23 |
|
Assigned To | msv => apn |
| 2015-01-23 18:23 |
|
Status | assigned => resolved |
| 2015-01-23 18:23 |
|
Status | resolved => reviewed |
| 2015-01-26 17:55 | apn | Note Added: 0036669 | |
| 2015-01-26 17:56 | apn | Assigned To | apn => bugmaster |
| 2015-01-26 17:56 | apn | Status | reviewed => tested |
| 2015-01-30 14:00 | bugmaster | Changeset attached | => occt master 07f1a2e6 |
| 2015-01-30 14:00 | bugmaster | Status | tested => verified |
| 2015-01-30 14:00 | bugmaster | Resolution | open => fixed |
| 2015-03-18 13:36 | git | Note Added: 0038563 | |
| 2015-05-14 15:29 |
|
Status | verified => closed |
| 2015-05-14 15:32 |
|
Fixed in Version | => 6.9.0 |