------------------------------------------ Common part ------------------------------------------ Please change the contractual agreement in new files to new style. All new methods should be updated with next pattern >>//======================================================================= >>// function : Add >>// purpose : >>//======================================================================= >> >>void ShapeProcess_AllOptions::Add (Handle(ShapeProcess_BaseOptions)& theOptions, Standard_Boolean theOverride) -> >>//======================================================================= >>// function : Add >>// purpose : >>//======================================================================= >>void ShapeProcess_AllOptions::Add (Handle(ShapeProcess_BaseOptions)& theOptions, Standard_Boolean theOverride) In cxx files should be #include of working file in the first place and splitted by new line from the other includes. src/XSAlgo/AlgoContainer.hxx ------------------------------------------ 34: "class XSAlgo_AlgoContainer" not needed. Should be removed. 35-36: doubled new lines 58-65: not general method naming within the class. Please use one style to make declaration ( for example, on one line [macros addition parameters and return type] and name and parameters on other lines) 87-88: doubled new lines 89-95: Do not cooment not used code. Please remove. ------------------------------------------ src/XSAlgo/AlgoContainer.cxx ------------------------------------------ 15-16: doubled new lines 15: please take a place an inclide for the declaration of working (AlgoContainer) class (move from the ::57) 58-59: doubled new lines 509: rudement new line ------------------------------------------ src/ShapeProcess/ShapeProcess_UOperator.hxx ------------------------------------------ 27: "class ShapeProcess_UOperator" not needed. Should be removed. 50: "protected:" not needed. Should be removed. ------------------------------------------ src/ShapeProcess/ShapeProcess_UOperator.cxx ------------------------------------------ 15-16: doubled new lines 19: #include please take a place an inclide for the declaration class (move from the ::57) ------------------------------------------ src/ShapeProcess/ShapeProcess_ShapeContext.hxx ------------------------------------------ 159: "protected:" not needed. Should be removed. 174: //! List of operations to perform on the shape Incorrect style for field description, use <>#ifdef OCCT_DEBUG >> // std::cout << "Modifier: " << std::endl; DumpMap (myMap); >>#endif not needed. Should be removed. 513-523: >>void ShapeProcess_ShapeContext::SetMessenger (const Handle(Message_Messenger)& theMessenger) >>{ >> if (theMessenger.IsNull()) >> { >> myMessenger = Message::DefaultMessenger(); >> } >> else >> { >> myMessenger = theMessenger; >> } >>} Please update description to help to work with null handle 484-497: >>void ShapeProcess_ShapeContext::MakeOperatorsList (NCollection_Sequence& theOperators, >> const TCollection_AsciiString& theSequence) >>{ >> TCollection_AsciiString anOperator; >> for (Standard_Integer i = 1;; i++) >> { >> anOperator = theSequence.Token (" \t,;", i); >> if (anOperator.Length () <= 0) >> { >> break; >> } >> theOperators.Append (anOperator); >> } >>} Very stange methods, that have no connections to the ShapeProcess_ShapeContext. Used twice in the all solution in XSAlgo_AlgoContainer and ShapeProcessAPI_ApplySequence Should be reworked or moved to the work place. ------------------------------------------ src/ShapeProcess/ShapeProcess_PredefinedOptions.hxx ------------------------------------------ 19-20 >>#include >> >>class ShapeProcess_BaseOptions; Repeating. Please remove "class ShapeProcess_BaseOptions" 32-36: >>//! Adds a set of options to the map >>Standard_EXPORT static void Add (Standard_CString theProcName, >> Handle(ShapeProcess_BaseOptions)& theOptions, >> Standard_Boolean theOverride = Standard_False); Standard_Boolean theOverride = Standard_False -> const Standard_Boolean ... ------------------------------------------ src/ShapeProcess/ShapeProcess_PredefinedOptions.cxx ------------------------------------------ 1-15: All style of the buttom file contractual agreement. Plees use new version. 16: please take a place an inclide for the declaration of working (ShapeProcess_PredefinedOptions) class (move from the ::18) 23-26 >>//======================================================================= >>// function : ShapeProcess_PredefinedOptions >>// purpose : Initializes a map with options for standard procedures >>//======================================================================= >>void ShapeProcess_PredefinedOptions::Init() Incorrect description ------------------------------------------ src/ShapeProcess/ShapeProcess_AllOptions.hxx ------------------------------------------ VERY STRANGE CLASS. I thins should be splitted to the some files. 69-70 >>/////////////////////////////////////////////////////////////////////////////////////// >>//! Parameters for ... >>class ShapeProcess_DirectFacesOptions : public ShapeProcess_BaseOptions What is it? A lot of this kind on the file. ------------------------------------------ src/ShapeProcess/ShapeProcess_OperatorOptions.cxx ------------------------------------------ 15-16: doubled new lines 16: please take a place an inclide for the declaration of working (ShapeProcess_OperatorOptions) class (move from the ::18) ...