View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0028877 | Open CASCADE | OCCT:Documentation | public | 2017-06-28 10:33 | 2017-09-29 16:28 |
| Reporter | kgv | Assigned To | bugmaster | ||
| Priority | normal | Severity | trivial | ||
| Status | closed | Resolution | fixed | ||
| Product Version | 6.8.0 | ||||
| Target Version | 7.2.0 | Fixed in Version | 7.2.0 | ||
| Summary | 0028877: Documentation - fix unclosed tag in coding_rules.md | ||||
| Description | The documentation from coding_rules.md contains an artifact due to unclosed tag (see ~~~~~{.cpp}):
Overriding virtual methods
Declaration of overriding method should contains specifiers "virtual" and "override" (using Standard_OVERRIDE alias for compatibility with old compilers).
class MyPackage_BaseClass
{
public:
Standard_EXPORT virtual Standard_Boolean Perform();
};
~~~~~{.cpp}
class MyPackage_MyClass : public MyPackage_BaseClass
{
public:
Standard_EXPORT virtual Standard_Boolean Perform() Standard_OVERRIDE;
};
This makes class definition more clear (virtual methods become highlighted).
| ||||
| Steps To Reproduce | N/A | ||||
| Tags | No tags attached. | ||||
| Test case number | Not required | ||||
|
|
Branch CR28877 has been created by kgv. SHA-1: 0f4f8d62da003d9e9fdc111e81ea58b606b2d32f Detailed log of new commits: Author: kgv Date: Wed Jun 28 10:36:59 2017 +0300 0028877: Documentation - fix unclosed tag in coding_rules.md |
|
|
Please take the patch. |
|
|
Dear BugMaster, Please integrate branch CR28877 into the occt git-repository master. |
|
|
Branch CR28877 has been deleted by kgv. SHA-1: 0f4f8d62da003d9e9fdc111e81ea58b606b2d32f |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2017-06-28 10:33 | kgv | New Issue | |
| 2017-06-28 10:33 | kgv | Assigned To | => ysn |
| 2017-06-28 10:34 | kgv | Relationship added | child of 0025182 |
| 2017-06-28 10:35 | kgv | Product Version | 7.0.0 => 6.8.0 |
| 2017-06-28 10:37 | git | Note Added: 0067758 | |
| 2017-06-28 10:37 | kgv | Note Added: 0067759 | |
| 2017-06-28 10:37 | kgv | Assigned To | ysn => bugmaster |
| 2017-06-28 10:37 | kgv | Severity | minor => trivial |
| 2017-06-28 10:37 | kgv | Status | new => resolved |
| 2017-06-28 10:37 | kgv | Status | resolved => reviewed |
| 2017-06-28 10:56 |
|
Note Added: 0067760 | |
| 2017-06-28 10:56 |
|
Status | reviewed => tested |
| 2017-06-28 10:56 |
|
Test case number | => Not required |
| 2017-06-30 12:01 | bugmaster | Changeset attached | => occt master a2a6c872 |
| 2017-06-30 12:01 | bugmaster | Status | tested => verified |
| 2017-06-30 12:01 | bugmaster | Resolution | open => fixed |
| 2017-07-03 08:45 | git | Note Added: 0067900 | |
| 2017-09-29 16:18 |
|
Fixed in Version | => 7.2.0 |
| 2017-09-29 16:28 |
|
Status | verified => closed |