Trimmed curve periodicity

Istvan Csanady's picture

Just found this:

Standard_Boolean Geom_TrimmedCurve::IsPeriodic () const
{
//return basisCurve->IsPeriodic();
return Standard_False;
}

What is the reason for that implementation? Shouldn't it

return basisCurve->IsPeriodic() && uTrim1 == basisCurve->FirstParameter() && uTrim2 == basisCurve->LastParameter();

?

Roman Lygin's picture

Minor correction

Rather this:

return basisCurve->IsPeriodic() && Abs (uTrim2 - uTrim1 - Period()) < Precision::PConfusion();

to account for trims not aligned with natural bounds but still taking entire period.

Istvan Csanady's picture

Yes. :)

Yes. :)

Istvan Csanady's picture

@OpenCASCADE team: isn't this

@OpenCASCADE team: isn't this a major issue? This could cause really strange bugs in my opinion, any comments on this? Or do I misunderstand something?

www.opencascade.com

Copyright 2011-2017
OPEN CASCADE SAS
Contact us